[FIXED] shipmarket - buying the same ships twice

[Cutpurse]

about 2 hours ago i bought 5 sotl from the market. i chose to individually deliver each of the 5, but only 3 of them was delivered to me. when i looked at their ship journals, i saw them showing log of me buying 2 of the ships twice:

Unnamed (#479055)Next

Day 3154 Built by My Crows (#87298)
Day 3157 Bought by Cutpurse (#66280)
Day 3157 Bought by Cutpurse (#66280)

Unnamed (#478643)Next

Day 3151 Built by pate (#89941)
Day 3154 Bought by My Crows (#87298)
Day 3157 Bought by Cutpurse (#66280)
Day 3157 Bought by Cutpurse (#66280)

in the ship market history it shows 5 ships being sold, yet i only got 3, so i think im missing either some credits or ships.

ive seen this before. i found in our mail history myself reporting same issue last year, which i then forgot:

i got a bug on ship market. i bought 2 similar sotl for 4 credits each. once auction was complete, i had them both delivered to prote at same time. i only had 1 ship delivered, tho the auction history shows 2 ships were sold. in ship history it shows as if i would have bought the same ship twice:

Unnamed (#446946)Next

Day 2835 Built by pate (#89941)
Day 2838 Bought by Cutpurse (#66280)
Day 2838 Bought by Cutpurse (#66280)

2020-06-18 16:38:40 (Chat reply)

[Captain Jack]

All ships appear delivered. 2 missing. Have you sold any ships to the shipwright perhaps?
I have not looked at the code, room for bug here is very slim as there are 2 logs for these transactions in order to ensure that nothing is missed. To put in analogy, bank transactions have 1.

[Captain Jack]

I will look at the code though, as it seems very odd.

[Captain Jack]

Well, I looked the database carefully and it seems that you have managed to bid on the same ship twice. This happened on two of ships.

This means that you spent credits twice. However, the system could not give you the same ship twice.

Therefore, the problem is that you were able to bid twice on the same ship. I can only think that this happened for 2 reasons combined:
1)The seller's mouse probably needs replacement.
2)The code needs to guard against this.

[Captain Jack]

I have issued a fix to this.
Like I said, this is a fix that prevents submission of same ship as two different auctions.

[Most Lee Harmless]

Query : was the seller paid twice for the sale?

*digs out ancient ratty old mouse*

[Captain Jack]

Yes. Old ratty mouses won't work anymore